Skip to content

Conversation

@dante4rt
Copy link

@dante4rt dante4rt commented Oct 28, 2025

Description

This pull request adds support for the Lisk and Lisk Sepolia EVM networks across the codebase. The changes ensure these networks are recognized, properly mapped, and have their USDC token information configured.

Lisk network support:

  • Added "lisk" and "lisk-sepolia" to the list of supported EVM networks in NetworkSchema, SupportedEVMNetworks, and mapped their network names to chain IDs in EvmNetworkToChainId (network.ts). [1] [2] [3]
  • Added USDC token address and name for both Lisk networks in the config object (config.ts).

Wallet and chain integration:

  • Imported lisk and liskSepolia chain definitions and updated getChainFromNetwork to support both new networks (wallet.ts). [1] [2]

Tests

The changes were verified with the following commands, and all tests passed.

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits

Copilot AI review requested due to automatic review settings October 28, 2025 13:44
@vercel
Copy link

vercel bot commented Oct 28, 2025

@dante4rt is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link

cb-heimdall commented Oct 28, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Lisk and Lisk Sepolia networks to the x402 codebase, enabling USDC token interactions on these EVM-compatible chains.

Key Changes:

  • Added Lisk (mainnet) and Lisk Sepolia (testnet) to the list of supported EVM networks
  • Configured USDC token addresses and names for both networks
  • Integrated Lisk chain definitions into the wallet utilities

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
typescript/packages/x402/src/types/shared/network.ts Added Lisk networks to the schema, supported networks list, and chain ID mappings
typescript/packages/x402/src/types/shared/evm/wallet.ts Imported Lisk chain definitions and added case handlers for chain resolution
typescript/packages/x402/src/types/shared/evm/config.ts Added USDC token configuration for both Lisk networks with addresses and names

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dante4rt
Copy link
Author

Hi @CarsonRoscoe, could you please review this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants